-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPS: Bump to 1.26 proper for Python 3.12 #55175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/unit-tests.yml
Outdated
@@ -234,7 +234,8 @@ jobs: | |||
/opt/python/cp311-cp311/bin/python -m venv ~/virtualenvs/pandas-dev | |||
. ~/virtualenvs/pandas-dev/bin/activate | |||
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.2.1 meson-python==0.13.1 | |||
python -m pip install --no-cache-dir versioneer[toml] cython numpy python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 pytest-asyncio>=0.17 hypothesis>=6.46.1 | |||
# No longer possible to easily compile numpy > 1.26 from source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes the source install difficult?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious about this too. Are the tests not even able to run due to installing numpy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy needs a BLAS which is not present on Github Actions to build, by default.
I didn't feel like spending time to fiddle around with the config settings for 32-bit (given its probably going to be removed sometime soon-ish), so I just left it. IMO, it's not the end of the world that its pinned, but if you want me to try to fiddle around, I can set some time towards the end of this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring to this failure fix? ebca6df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice.
Thanks for the fix!
Thanks @lithomas1 |
…hon 3.12) (#55203) Backport PR #55175: DEPS: Bump to 1.26 proper for Python 3.12 Co-authored-by: Thomas Li <[email protected]>
* DEPS: Bump to 1.26 proper for Python 3.12 * Update unit-tests.yml * Update unit-tests.yml * revert hack
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.